A faster way to compute the largest prime factor





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ margin-bottom:0;
}







1












$begingroup$


I am self-learning js and came across this problem(#3) from the Euler Project




The prime factors of 13195 are 5, 7, 13 and 29.



What is the largest prime factor of the number 600851475143 ?




Logic:




  • Have an array primes to store all the prime numbers less than number


  • Loop through the odd numbers only below number to check for primes using i



  • Check if i is divisible by any of the elements already in primes.




    • If yes, isPrime = false and break the for loop for j by j=primesLength

    • If not, isPrime = true




  • If isPrime == true then add i to the array primes and check if number%i == 0




    • If number%i == 0% update the value of factor as factor = i



  • Return factor after looping through all the numbers below number



My code:






function problem3(number){

	let factor = 1;

	let primes = [2];	//array to store prime numbers



	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers

		let isPrime = true;

		let primesLength= primes.length;



		for(let j=0; j< primesLength; j++){

			if(i%primes[j]==0){

				isPrime = false;

				j=primesLength;	//to break the for loop

			}

		}



		if(isPrime == true){

			primes.push(i);

			if(number%i == 0){

				factor = i;

			}

		}

	}

	return  factor;

}



console.log(problem3(600851475143));





It is working perfectly for small numbers, but is quite very slow for 600851475143. What should I change in this code to make the computation faster?






javascript beginner programming-challenge time-limit-exceeded primes







share|improve this question









New contributor




Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$



















    1












    $begingroup$


    I am self-learning js and came across this problem(#3) from the Euler Project




    The prime factors of 13195 are 5, 7, 13 and 29.



    What is the largest prime factor of the number 600851475143 ?




    Logic:




    • Have an array primes to store all the prime numbers less than number


    • Loop through the odd numbers only below number to check for primes using i



    • Check if i is divisible by any of the elements already in primes.




      • If yes, isPrime = false and break the for loop for j by j=primesLength

      • If not, isPrime = true




    • If isPrime == true then add i to the array primes and check if number%i == 0




      • If number%i == 0% update the value of factor as factor = i



    • Return factor after looping through all the numbers below number



    My code:






    function problem3(number){
    
	let factor = 1;
    
	let primes = [2];	//array to store prime numbers
    

    
	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers
    
		let isPrime = true;
    
		let primesLength= primes.length;
    

    
		for(let j=0; j< primesLength; j++){
    
			if(i%primes[j]==0){
    
				isPrime = false;
    
				j=primesLength;	//to break the for loop
    
			}
    
		}
    

    
		if(isPrime == true){
    
			primes.push(i);
    
			if(number%i == 0){
    
				factor = i;
    
			}
    
		}
    
	}
    
	return  factor;
    
}
    

    
console.log(problem3(600851475143));





    It is working perfectly for small numbers, but is quite very slow for 600851475143. What should I change in this code to make the computation faster?






    javascript beginner programming-challenge time-limit-exceeded primes







    share|improve this question









    New contributor




    Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      1












      1








      1





      $begingroup$


      I am self-learning js and came across this problem(#3) from the Euler Project




      The prime factors of 13195 are 5, 7, 13 and 29.



      What is the largest prime factor of the number 600851475143 ?




      Logic:




      • Have an array primes to store all the prime numbers less than number


      • Loop through the odd numbers only below number to check for primes using i



      • Check if i is divisible by any of the elements already in primes.




        • If yes, isPrime = false and break the for loop for j by j=primesLength

        • If not, isPrime = true




      • If isPrime == true then add i to the array primes and check if number%i == 0




        • If number%i == 0% update the value of factor as factor = i



      • Return factor after looping through all the numbers below number



      My code:






      function problem3(number){
      
	let factor = 1;
      
	let primes = [2];	//array to store prime numbers
      

      
	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers
      
		let isPrime = true;
      
		let primesLength= primes.length;
      

      
		for(let j=0; j< primesLength; j++){
      
			if(i%primes[j]==0){
      
				isPrime = false;
      
				j=primesLength;	//to break the for loop
      
			}
      
		}
      

      
		if(isPrime == true){
      
			primes.push(i);
      
			if(number%i == 0){
      
				factor = i;
      
			}
      
		}
      
	}
      
	return  factor;
      
}
      

      
console.log(problem3(600851475143));





      It is working perfectly for small numbers, but is quite very slow for 600851475143. What should I change in this code to make the computation faster?






      javascript beginner programming-challenge time-limit-exceeded primes







      share|improve this question









      New contributor




      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I am self-learning js and came across this problem(#3) from the Euler Project




      The prime factors of 13195 are 5, 7, 13 and 29.



      What is the largest prime factor of the number 600851475143 ?




      Logic:




      • Have an array primes to store all the prime numbers less than number


      • Loop through the odd numbers only below number to check for primes using i



      • Check if i is divisible by any of the elements already in primes.




        • If yes, isPrime = false and break the for loop for j by j=primesLength

        • If not, isPrime = true




      • If isPrime == true then add i to the array primes and check if number%i == 0




        • If number%i == 0% update the value of factor as factor = i



      • Return factor after looping through all the numbers below number



      My code:






      function problem3(number){
      
	let factor = 1;
      
	let primes = [2];	//array to store prime numbers
      

      
	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers
      
		let isPrime = true;
      
		let primesLength= primes.length;
      

      
		for(let j=0; j< primesLength; j++){
      
			if(i%primes[j]==0){
      
				isPrime = false;
      
				j=primesLength;	//to break the for loop
      
			}
      
		}
      

      
		if(isPrime == true){
      
			primes.push(i);
      
			if(number%i == 0){
      
				factor = i;
      
			}
      
		}
      
	}
      
	return  factor;
      
}
      

      
console.log(problem3(600851475143));





      It is working perfectly for small numbers, but is quite very slow for 600851475143. What should I change in this code to make the computation faster?






      function problem3(number){
      
	let factor = 1;
      
	let primes = [2];	//array to store prime numbers
      

      
	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers
      
		let isPrime = true;
      
		let primesLength= primes.length;
      

      
		for(let j=0; j< primesLength; j++){
      
			if(i%primes[j]==0){
      
				isPrime = false;
      
				j=primesLength;	//to break the for loop
      
			}
      
		}
      

      
		if(isPrime == true){
      
			primes.push(i);
      
			if(number%i == 0){
      
				factor = i;
      
			}
      
		}
      
	}
      
	return  factor;
      
}
      

      
console.log(problem3(600851475143));





      function problem3(number){
      
	let factor = 1;
      
	let primes = [2];	//array to store prime numbers
      

      
	for(let i=3; i<number; i=i+2){		//Increment i by 2 to loop through only odd numbers
      
		let isPrime = true;
      
		let primesLength= primes.length;
      

      
		for(let j=0; j< primesLength; j++){
      
			if(i%primes[j]==0){
      
				isPrime = false;
      
				j=primesLength;	//to break the for loop
      
			}
      
		}
      

      
		if(isPrime == true){
      
			primes.push(i);
      
			if(number%i == 0){
      
				factor = i;
      
			}
      
		}
      
	}
      
	return  factor;
      
}
      

      
console.log(problem3(600851475143));





      javascript beginner programming-challenge time-limit-exceeded primes




      javascript beginner programming-challenge time-limit-exceeded primes






      share|improve this question









      New contributor




      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 1 hour ago









      200_success

      131k17157422




      131k17157422






      New contributor




      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 2 hours ago









      EagleEagle

      1085




      1085




      New contributor




      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Eagle is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          2 Answers
          2






          active

          oldest

          votes


















          3












          $begingroup$

          There are many questions about Project Euler 3 on this site already. The trick is to pick an algorithm that…




          • Reduces n whenever you find a factor, so that you don't need to consider factors anywhere near as large as 600851475143

          • Only finds prime factors, and never composite factors, so that you never need to explicitly test for primality.


          Your algorithm suffers on both criteria: the outer for loop goes all the way up to 600851475143 (which is insane), and you're testing each of those numbers for primality (which is incredibly computationally expensive).






          share|improve this answer









          $endgroup$





















            1












            $begingroup$

            The first problem is that you are trying to find all prime numbers under number. The number of prime numbers under x is approximately x/ln(x) which is around 22153972243.4 for our specific value of x



            This is way too big ! So even if you where capable of obtaining each of these prime numbers in constant time it would take too much time.



            This tells us this approach is most likely unfixable.






            share|improve this answer








            New contributor




            Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
            Check out our Code of Conduct.






            $endgroup$














              Your Answer






              StackExchange.ifUsing("editor", function () {
              StackExchange.using("externalEditor", function () {
              StackExchange.using("snippets", function () {
              StackExchange.snippets.init();
              });
              });
              }, "code-snippets");

              StackExchange.ready(function() {
              var channelOptions = {
              tags: "".split(" "),
              id: "196"
              };
              initTagRenderer("".split(" "), "".split(" "), channelOptions);

              StackExchange.using("externalEditor", function() {
              // Have to fire editor after snippets, if snippets enabled
              if (StackExchange.settings.snippets.snippetsEnabled) {
              StackExchange.using("snippets", function() {
              createEditor();
              });
              }
              else {
              createEditor();
              }
              });

              function createEditor() {
              StackExchange.prepareEditor({
              heartbeatType: 'answer',
              autoActivateHeartbeat: false,
              convertImagesToLinks: false,
              noModals: true,
              showLowRepImageUploadWarning: true,
              reputationToPostImages: null,
              bindNavPrevention: true,
              postfix: "",
              imageUploader: {
              brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
              contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
              allowUrls: true
              },
              onDemand: true,
              discardSelector: ".discard-answer"
              ,immediatelyShowMarkdownHelp:true
              });


              }
              });






              Eagle is a new contributor. Be nice, and check out our Code of Conduct.










              draft saved

              draft discarded


















              StackExchange.ready(
              function () {
              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f219063%2fa-faster-way-to-compute-the-largest-prime-factor%23new-answer', 'question_page');
              }
              );

              Post as a guest















              Required, but never shown

























              2 Answers
              2






              active

              oldest

              votes








              2 Answers
              2






              active

              oldest

              votes









              active

              oldest

              votes






              active

              oldest

              votes









              3












              $begingroup$

              There are many questions about Project Euler 3 on this site already. The trick is to pick an algorithm that…




              • Reduces n whenever you find a factor, so that you don't need to consider factors anywhere near as large as 600851475143

              • Only finds prime factors, and never composite factors, so that you never need to explicitly test for primality.


              Your algorithm suffers on both criteria: the outer for loop goes all the way up to 600851475143 (which is insane), and you're testing each of those numbers for primality (which is incredibly computationally expensive).






              share|improve this answer









              $endgroup$


















                3












                $begingroup$

                There are many questions about Project Euler 3 on this site already. The trick is to pick an algorithm that…




                • Reduces n whenever you find a factor, so that you don't need to consider factors anywhere near as large as 600851475143

                • Only finds prime factors, and never composite factors, so that you never need to explicitly test for primality.


                Your algorithm suffers on both criteria: the outer for loop goes all the way up to 600851475143 (which is insane), and you're testing each of those numbers for primality (which is incredibly computationally expensive).






                share|improve this answer









                $endgroup$
















                  3












                  3








                  3





                  $begingroup$

                  There are many questions about Project Euler 3 on this site already. The trick is to pick an algorithm that…




                  • Reduces n whenever you find a factor, so that you don't need to consider factors anywhere near as large as 600851475143

                  • Only finds prime factors, and never composite factors, so that you never need to explicitly test for primality.


                  Your algorithm suffers on both criteria: the outer for loop goes all the way up to 600851475143 (which is insane), and you're testing each of those numbers for primality (which is incredibly computationally expensive).






                  share|improve this answer









                  $endgroup$



                  There are many questions about Project Euler 3 on this site already. The trick is to pick an algorithm that…




                  • Reduces n whenever you find a factor, so that you don't need to consider factors anywhere near as large as 600851475143

                  • Only finds prime factors, and never composite factors, so that you never need to explicitly test for primality.


                  Your algorithm suffers on both criteria: the outer for loop goes all the way up to 600851475143 (which is insane), and you're testing each of those numbers for primality (which is incredibly computationally expensive).







                  share|improve this answer












                  share|improve this answer



                  share|improve this answer










                  answered 1 hour ago









                  200_success200_success

                  131k17157422




                  131k17157422

























                      1












                      $begingroup$

                      The first problem is that you are trying to find all prime numbers under number. The number of prime numbers under x is approximately x/ln(x) which is around 22153972243.4 for our specific value of x



                      This is way too big ! So even if you where capable of obtaining each of these prime numbers in constant time it would take too much time.



                      This tells us this approach is most likely unfixable.






                      share|improve this answer








                      New contributor




                      Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                      Check out our Code of Conduct.






                      $endgroup$


















                        1












                        $begingroup$

                        The first problem is that you are trying to find all prime numbers under number. The number of prime numbers under x is approximately x/ln(x) which is around 22153972243.4 for our specific value of x



                        This is way too big ! So even if you where capable of obtaining each of these prime numbers in constant time it would take too much time.



                        This tells us this approach is most likely unfixable.






                        share|improve this answer








                        New contributor




                        Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                        Check out our Code of Conduct.






                        $endgroup$
















                          1












                          1








                          1





                          $begingroup$

                          The first problem is that you are trying to find all prime numbers under number. The number of prime numbers under x is approximately x/ln(x) which is around 22153972243.4 for our specific value of x



                          This is way too big ! So even if you where capable of obtaining each of these prime numbers in constant time it would take too much time.



                          This tells us this approach is most likely unfixable.






                          share|improve this answer








                          New contributor




                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.






                          $endgroup$



                          The first problem is that you are trying to find all prime numbers under number. The number of prime numbers under x is approximately x/ln(x) which is around 22153972243.4 for our specific value of x



                          This is way too big ! So even if you where capable of obtaining each of these prime numbers in constant time it would take too much time.



                          This tells us this approach is most likely unfixable.







                          share|improve this answer








                          New contributor




                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.









                          share|improve this answer



                          share|improve this answer






                          New contributor




                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.









                          answered 57 mins ago









                          Jorge FernándezJorge Fernández

                          1645




                          1645




                          New contributor




                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.





                          New contributor





                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.






                          Jorge Fernández is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
                          Check out our Code of Conduct.






















                              Eagle is a new contributor. Be nice, and check out our Code of Conduct.










                              draft saved

                              draft discarded


















                              Eagle is a new contributor. Be nice, and check out our Code of Conduct.













                              Eagle is a new contributor. Be nice, and check out our Code of Conduct.












                              Eagle is a new contributor. Be nice, and check out our Code of Conduct.
















                              Thanks for contributing an answer to Code Review Stack Exchange!


                              • Please be sure to answer the question. Provide details and share your research!

                              But avoid …



                              • Asking for help, clarification, or responding to other answers.

                              • Making statements based on opinion; back them up with references or personal experience.


                              Use MathJax to format equations. MathJax reference.


                              To learn more, see our tips on writing great answers.




                              draft saved


                              draft discarded














                              StackExchange.ready(
                              function () {
                              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f219063%2fa-faster-way-to-compute-the-largest-prime-factor%23new-answer', 'question_page');
                              }
                              );

                              Post as a guest















                              Required, but never shown





















































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown

































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown







                              -

                              Popular posts from this blog

                              Knooppunt Holsloot

                              Image
                              Knooppunt Holsloot Kenmerken Wegen A37 × N34 Type knooppunt klaverblad Portaal     Verkeer & Vervoer Knooppunt Holsloot is een verkeersknooppunt op de kruising van de autosnelweg A37 en de N34 in Drenthe, tussen Emmen en Coevorden. Oorspronkelijk was deze aansluiting een afritconstructie van het type Haarlemmermeeraansluiting, zoals bij Knooppunt Hooipolder. Sinds 2002 is het knooppunt omgebouwd tot een volledig klaverblad. Als noviteit werd hier voor het eerst gebruikgemaakt van dimbare verlichting in plaats van de normale vaste tijden waarop de verlichting aan en uit gaat, wat een grote kostenbesparing opleverde. [1] Dat Holsloot als volwaardig knooppunt is uitgevoerd, waarbij alle verkeersstromen en afbuigingen ononderbroken kunnen doorgaan, is uitzonderlijk. Het betreft hier namelijk een aansluiting tussen een autosnelweg en niet-snelweg. Een vergelijkbare situatie treft men nabij Hoensbroek bij het knooppunt Ten Esschen.     Aa
                              Read more

                              Altaar (religie)

                              Image
                              Deel van de serie over kerkelijk gerei waaronder paramenten en liturgisch vaatwerk gebruikt in de liturgie Liturgisch vaatwerk Vasa sacra Miskelk · Pateen Kelklepeltje Ciborie · Monstrans Pyxis · Custodiale Vasa non sacra Ampullen · Wijwatervat Olievaatje Wierookvat · Ablutievat Paramenten Amict · Albe · Baarkleed · Cingel Tuniek · Dalmatiek · Fanon Kazuifel · Manipel · Stola Gremiale · Benedictievelum Mijter Koorkledij Rochet · Superplie Koorkap · Cappa magna Kovel Kelkgerei Bursa · Kelkvelum Ciborievelum Kerklinnen Corporale · Kelkdoekje Lavabodoekje · Palla Altaardwaal Kerkinterieur Altaar · Ambo Biechtstoel · Communiebank Doksaal · Doopvont Faldistorium Godslamp · Hoogaltaar Heilig Kruisaltaar Katheder · Preekstoel Sedilia Tabernakel · Volksaltaar Liturgische boeken Altaarmissaal Benedictionale · Brevier Evangeliarium · Evangelistarium Graduale · Kyriale Lectionarium Psalter · Rituaal Sacramentarium · Volksmissaal Overige Flambou
                              Read more

                              Gregoriusmis

                              Image
                              Een afbeelding van de Gregoriusmis uit een getijdenboek gemaakt in de zuidelijke Nederlanden tussen 1500 en 1525 Gregoriusmis, Meester van het Akense Altaar, ca. 1500-1525. Collectie Museum Catharijneconvent De Gregoriusmis of de Mis van Sint Gregorius is een motief in katholieke kunst, dat het eerst verscheen in de late Middeleeuwen en dat nog steeds werd gebruikt tijdens de contrareformatie. Paus Gregorius I (ca. 540-604) is afgebeeld, de H. Mis opdragend, terwijl Christus als de Man van Smarten verschijnt op het altaar dat voor Sint Gregorius staat. Volgens de legende had St. Gregorius gebeden om een teken voor een betwijfelaar van de transsubstantiatieleer, waarop de lijdende Christus tijdens het opdragen van de Mis verscheen om hem te overtuigen en waarbij zijn bloed in de altaarkelk liep. Vaak zijn ook de passiewerktuigen afgebeeld. Zie de categorie Mass of Saint Gregory van Wikimedia Commons voor mediabestanden over dit onderwerp. This page is onl
                              Read more